Review Request 123459: Lockscreen: It shouldn't show the battery information on system which they don't have a battery
David Edmundson
david at davidedmundson.co.uk
Tue Apr 21 21:47:39 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123459/#review79311
-----------------------------------------------------------
lookandfeel/contents/components/InfoPane.qml (line 47)
<https://git.reviewboard.kde.org/r/123459/#comment54152>
there's a visible here.
If your two lines are needed, this isn't.
Or this should be changed to the battery.hasBattery instead.
- David Edmundson
On April 21, 2015, 9:18 p.m., Antonis Tsiapaliokas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123459/
> -----------------------------------------------------------
>
> (Updated April 21, 2015, 9:18 p.m.)
>
>
> Review request for Plasma.
>
>
> Bugs: 346441
> https://bugs.kde.org/show_bug.cgi?id=346441
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> The battery information shouldn't be shown on systems which they don't have battery (desktops/laptop without battery).
>
>
> Diffs
> -----
>
> lookandfeel/contents/components/InfoPane.qml 18739ad
>
> Diff: https://git.reviewboard.kde.org/r/123459/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> no battery after
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/21/d3e0b27b-e695-46a2-b56a-dc60c9679309__no_battery_after.png
> no battery before
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/21/884a20d3-852c-4b1d-a588-7bb47e725011__no_battery_before.png
>
>
> Thanks,
>
> Antonis Tsiapaliokas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150421/21a722ca/attachment-0001.html>
More information about the Plasma-devel
mailing list