Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

[Bernhard Friedreich]

> On April 18, 2015, 5:33 nachm., Kai Uwe Broulik wrote:
> > applets/timer/package/contents/ui/timer.qml, lines 221-225
> > <https://git.reviewboard.kde.org/r/123420/diff/1/?file=362055#file362055line221>
> >
> >     Can be simplified to
> >     operation.summary = notificationText || i18n("Timer finished")

Ah nice :) also using this for the appName now :)


> On April 18, 2015, 5:33 nachm., Kai Uwe Broulik wrote:
> > applets/timer/package/contents/ui/timer.qml, line 56
> > <https://git.reviewboard.kde.org/r/123420/diff/1/?file=362055#file362055line56>
> >
> >     Make that proper if statements, complex ternary operators are hard to follow

yeah this one grew too big..


- Bernhard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123420/#review79175
-----------------------------------------------------------


On April 18, 2015, 6:14 nachm., Bernhard Friedreich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123420/
> -----------------------------------------------------------
> 
> (Updated April 18, 2015, 6:14 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Compact Mode: shows the name of the timer and the remaining seconds
> Using the tooltip it is possible to glance at the timer without
> opening the full representation by clicking
> 
> Full Mode: shows information that you can use the scroll wheel to
> change the digits and choose from predefined timers using the
> context menu
> 
> BUG: 259630
> 
> Added missing i18n for notifaction finished text
> 
> 
> Diffs
> -----
> 
>   applets/timer/package/contents/ui/timer.qml 2f7af4f3815b3c8a43e4a7b32d6a020cf3dc0848 
> 
> Diff: https://git.reviewboard.kde.org/r/123420/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Compact mode running
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/9b90a460-8808-49bd-969f-cedcc9251f32__tooltip_compact_mode_running.png
> Compact mode
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/f548efea-0635-4647-b9a3-6d2d4c497bfa__tooltip_compact_mode.png
> Full mode running
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/c7370926-e497-43f1-a254-8448e4ffbdf0__tooltip_full_mode_running.png
> Full mode
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/e4068531-ced8-4487-8b2e-d95b339d7e53__tooltip_full_mode.png
> Compact mode with title and time already set
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/4d574a75-d469-4f65-acb7-6961fe567782__tooltip_compact_mode_title_set.png
> 
> 
> Thanks,
> 
> Bernhard Friedreich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150418/df82c992/attachment.html>