Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode

Bernhard Friedreich friesoft at gmail.com
Sat Apr 18 18:14:05 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123420/
-----------------------------------------------------------

(Updated April 18, 2015, 6:14 nachm.)


Review request for Plasma.


Changes
-------

Fixed issues pointed out by Kai Uwe Broulik. Thanks for the review :)


Repository: kdeplasma-addons


Description
-------

Compact Mode: shows the name of the timer and the remaining seconds
Using the tooltip it is possible to glance at the timer without
opening the full representation by clicking

Full Mode: shows information that you can use the scroll wheel to
change the digits and choose from predefined timers using the
context menu

BUG: 259630

Added missing i18n for notifaction finished text


Diffs (updated)
-----

  applets/timer/package/contents/ui/timer.qml 2f7af4f3815b3c8a43e4a7b32d6a020cf3dc0848 

Diff: https://git.reviewboard.kde.org/r/123420/diff/


Testing
-------


File Attachments
----------------

Compact mode running
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/9b90a460-8808-49bd-969f-cedcc9251f32__tooltip_compact_mode_running.png
Compact mode
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/f548efea-0635-4647-b9a3-6d2d4c497bfa__tooltip_compact_mode.png
Full mode running
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/c7370926-e497-43f1-a254-8448e4ffbdf0__tooltip_full_mode_running.png
Full mode
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/e4068531-ced8-4487-8b2e-d95b339d7e53__tooltip_full_mode.png
Compact mode with title and time already set
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/4d574a75-d469-4f65-acb7-6961fe567782__tooltip_compact_mode_title_set.png


Thanks,

Bernhard Friedreich

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150418/bb8f95fc/attachment-0001.html>


More information about the Plasma-devel mailing list