Review Request 123280: Kickoff - Properly register recent applications right after startup

Anthony Vital anthony.vital at gmail.com
Thu Apr 16 13:09:09 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123280/
-----------------------------------------------------------

(Updated avr. 16, 2015, 1:09 apr├Ęs-midi)


Review request for Plasma.


Changes
-------

Different approach: we fix the problem in the internal application list. 
Say you start Kickoff, and click on an application in the favorites. Kickoff will populate a list from the saved items in the config file, and assign them timestamps (current time, current time + 1s, etc...). Then it will add the new entry with a timestamp (current time). This last entry will have a timestamp older than the artificial timestamps assigned to the items from the config file. 
We obviously don't want this so we make sure the artificial timestamps are always older than the current time.


Repository: plasma-desktop


Description (updated)
-------

This does two things:
- Instantiate the RecentlyUsedModel at startup, otherwise it's not available
until the History tab is opened and this leads to some mixing in the recent
apps list/the list not being updated until then.~~

- Move the registration of the service handler to the launcher, so that the
apps launched from the Favorites tab are registered without having to open
the Applications tab first.


Diffs (updated)
-----

  applets/kickoff/core/applicationmodel.cpp 9af58a36d5c3349ad1f2bffd0f7f93eebd99663e 
  applets/kickoff/core/recentapplications.cpp 6c60fedcca1b0818179171a2d65c36ed3dd66787 
  applets/kickoff/core/urlitemlauncher.cpp 58a6c20cec60ede54ea55d927064eaf8af9b4f46 

Diff: https://git.reviewboard.kde.org/r/123280/diff/


Testing
-------

Launched applications from Favorites and Applications tab without opening the History tab first, items are added correctly.


Thanks,

Anthony Vital

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150416/e9b53bba/attachment-0001.html>


More information about the Plasma-devel mailing list