Review Request 123280: Kickoff - Properly register recent applications right after startup

[Anthony Vital]

> On avr. 6, 2015, 11:20 après-midi, David Edmundson wrote:
> > I don't understand the moving the recently used model startup part. 
> > 
> > What's broken about loading it later?

When you launch an application right after startup, an internal list is populated by loading the recent applications previously saved from the config file. Only then, the application launched is added to the list, at the end. If the RecentlyUsedModel is instantiated after that, the list will be used as it is, meaning the most recently used application will be at the bottom.
The RecentlyUsedModel is supposed to catch a signal when a new application has been launched, effectively sorting the list. So by instantiating the model early, we ensure that the list will be sorted.
Maybe this could be fixed differently, but it makes sense to me to have the model available immediately.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123280/#review78581
-----------------------------------------------------------


On avr. 6, 2015, 9:35 après-midi, Anthony Vital wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123280/
> -----------------------------------------------------------
> 
> (Updated avr. 6, 2015, 9:35 après-midi)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This does two things:
> - Instantiate the RecentlyUsedModel at startup, otherwise it's not available
> until the History tab is opened and this leads to some mixing in the recent
> apps list/the list not being updated until then.
> - Move the registration of the service handler to the launcher, so that the
> apps launched from the Favorites tab are registered without having to open
> the Applications tab first.
> 
> 
> Diffs
> -----
> 
>   applets/kickoff/core/applicationmodel.cpp 9af58a36d5c3349ad1f2bffd0f7f93eebd99663e 
>   applets/kickoff/core/urlitemlauncher.cpp 58a6c20cec60ede54ea55d927064eaf8af9b4f46 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 15dde962f2321d9b186c9d73246491dc48b398bb 
>   applets/kickoff/package/contents/ui/RecentlyUsedView.qml df25db21db4a6bd764dee3ff8583e2bdc35fe341 
> 
> Diff: https://git.reviewboard.kde.org/r/123280/diff/
> 
> 
> Testing
> -------
> 
> Launched applications from Favorites and Applications tab without opening the History tab first, items are added correctly.
> 
> 
> Thanks,
> 
> Anthony Vital
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150407/d086f173/attachment.html>