Review Request 123332: Timer: Added config ui for notification and title text

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123332/#review78989
-----------------------------------------------------------



applets/timer/package/contents/ui/configAppearance.qml (line 44)
<https://git.reviewboard.kde.org/r/123332/#comment53981>

    This is the line that doesn't work.
    
    Layout.property is a hint for the parent item, if and only if the parent item item is a layout.
    
    GroupBox is not a layout, it's an item. So this does nothing.
    
    This means we have nothing telling this layout that it should be as big as the parent. It might be on first open, but it's not bound to anything.
    
    The layout in the groupbox needs to anchors.fill: parent to tell it to fill the groupbox. 
    
    Same for the other groupbox below.
    
    Hope that makes sense? Ping me on IRC if it doesn't.


- David Edmundson


On April 13, 2015, 7:33 p.m., Bernhard Friedreich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123332/
> -----------------------------------------------------------
> 
> (Updated April 13, 2015, 7:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Added config ui for specifying a title text
> Added config ui for disabling the notification (default: enabled)
> Added config ui for configuring the notification text
> 
> 
> Diffs
> -----
> 
>   applets/timer/package/contents/config/main.xml 886bcd413ff68b4b5b092409dbc5f0e4aff273dc 
>   applets/timer/package/contents/ui/configAdvanced.qml c315c89249ae5f926c46a901e0358162a067cea4 
>   applets/timer/package/contents/ui/configAppearance.qml ceb97326b8192a9dfe80b6753c0fd0a7e3010095 
>   applets/timer/package/contents/ui/timer.qml 82fee524f51f06f522fc8c556a7454ab6840d1a3 
> 
> Diff: https://git.reviewboard.kde.org/r/123332/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Appearance Config Ui (showing the defaults)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/11/7628230f-9be6-4c13-b57d-584cb56043bc__tab_appearance_default.png
> 
> 
> Thanks,
> 
> Bernhard Friedreich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150415/787416b5/attachment.html>