<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123332/">https://git.reviewboard.kde.org/r/123332/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123332/diff/2/?file=361044#file361044line44" style="color: black; font-weight: bold; text-decoration: underline;">applets/timer/package/contents/ui/configAppearance.qml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">44</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">QtLayouts.Layout.fillWidth:</span> <span class="kc">true</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is the line that doesn't work.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Layout.property is a hint for the parent item, if and only if the parent item item is a layout.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">GroupBox is not a layout, it's an item. So this does nothing.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This means we have nothing telling this layout that it should be as big as the parent. It might be on first open, but it's not bound to anything.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The layout in the groupbox needs to anchors.fill: parent to tell it to fill the groupbox. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Same for the other groupbox below.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hope that makes sense? Ping me on IRC if it doesn't.</p></pre>
</div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On April 13th, 2015, 7:33 p.m. UTC, Bernhard Friedreich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Bernhard Friedreich.</div>
<p style="color: grey;"><i>Updated April 13, 2015, 7:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added config ui for specifying a title text
Added config ui for disabling the notification (default: enabled)
Added config ui for configuring the notification text</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/timer/package/contents/config/main.xml <span style="color: grey">(886bcd413ff68b4b5b092409dbc5f0e4aff273dc)</span></li>
<li>applets/timer/package/contents/ui/configAdvanced.qml <span style="color: grey">(c315c89249ae5f926c46a901e0358162a067cea4)</span></li>
<li>applets/timer/package/contents/ui/configAppearance.qml <span style="color: grey">(ceb97326b8192a9dfe80b6753c0fd0a7e3010095)</span></li>
<li>applets/timer/package/contents/ui/timer.qml <span style="color: grey">(82fee524f51f06f522fc8c556a7454ab6840d1a3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123332/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/11/7628230f-9be6-4c13-b57d-584cb56043bc__tab_appearance_default.png">Appearance Config Ui (showing the defaults)</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>