Review Request 123364: Fix wrong "when" condition in GroupExpanderOverlay.qml

[Xuetian Weng]

> On April 15, 2015, 11:44 a.m., Eike Hein wrote:
> > This states prop was written by Marco one day, so I'd like him to comment on why it doesn't just use BottomEdge.

I think the reason is location can have 7 different values. The other three are "Floating", "Desktop", "FullScreen".

Actually this part of code can be even simpler, by removing the "bottom" state, and move the anchor value in "bottom" to the item itself. See http://doc.qt.io/qt-5/qml-qtquick-state.html (Search "default state").


- Xuetian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123364/#review78963
-----------------------------------------------------------


On April 15, 2015, 6:23 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123364/
> -----------------------------------------------------------
> 
> (Updated April 15, 2015, 6:23 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> I assume this boolean expression should be conjunction instead of disjunction.
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/GroupExpanderOverlay.qml d04ae98 
> 
> Diff: https://git.reviewboard.kde.org/r/123364/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150415/223e109a/attachment.html>