Review Request 123364: Fix wrong "when" condition in GroupExpanderOverlay.qml

Eike Hein hein at kde.org
Wed Apr 15 11:44:46 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123364/#review78963
-----------------------------------------------------------


This states prop was written by Marco one day, so I'd like him to comment on why it doesn't just use BottomEdge.

- Eike Hein


On April 15, 2015, 6:23 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123364/
> -----------------------------------------------------------
> 
> (Updated April 15, 2015, 6:23 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> I assume this boolean expression should be conjunction instead of disjunction.
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/GroupExpanderOverlay.qml d04ae98 
> 
> Diff: https://git.reviewboard.kde.org/r/123364/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150415/e63c889d/attachment.html>


More information about the Plasma-devel mailing list