Review Request 123332: Timer: Added config ui for notification and title text

[Bernhard Friedreich]

> On April 11, 2015, 3 nachm., David Edmundson wrote:
> > applets/timer/package/contents/ui/configAppearance.qml, line 91
> > <https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91>
> >
> >     use Layout.fillWith: true ?
> 
> Bernhard Friedreich wrote:
>     using QtLayouts.Layout.fillWidth: true doesn't work for me :(
>     I've set it in all layers I think: the GroupBox, the ColumnLayout, the RowLayout and finally the TextField but it stays small...
> 
> Bernhard Friedreich wrote:
>     any ideas on this? can't get it to work..
> 
> Martin Klapetek wrote:
>     You should use only Layout.fillWidth, not QtLayouts.Layout I think? It's just an attached property, that's never with the import name
> 
> Bernhard Friedreich wrote:
>     mhm.. according to this page [1] it must be imported using e.g. "import QtQuick.Layouts 1.1 as QtLayouts"
>     therefore my code looks like "QtLayouts.Layout.fillWidth: true" but doesn't work :(
>     
>     
>     [1]: http://doc.qt.io/qt-5/qml-qtquick-layouts-layout.html#fillWidth-attached-prop
> 
> Bernhard Friedreich wrote:
>     removing the alias and just using "Layout.fillWidth: true" doesn't work either..
> 
> Kai Uwe Broulik wrote:
>     Well, the parent Layout doesn't have a width either, so it cannot span. Add a Layout.fillWidth to the parent one as well, looks like you forgot one.

I have added those locally already but it doesn't change anything. just updated the reviewrequest with the latest diff containig the fillWidth for every layer..


- Bernhard


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123332/#review78812
-----------------------------------------------------------


On April 13, 2015, 7:33 nachm., Bernhard Friedreich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123332/
> -----------------------------------------------------------
> 
> (Updated April 13, 2015, 7:33 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> Added config ui for specifying a title text
> Added config ui for disabling the notification (default: enabled)
> Added config ui for configuring the notification text
> 
> 
> Diffs
> -----
> 
>   applets/timer/package/contents/config/main.xml 886bcd413ff68b4b5b092409dbc5f0e4aff273dc 
>   applets/timer/package/contents/ui/configAdvanced.qml c315c89249ae5f926c46a901e0358162a067cea4 
>   applets/timer/package/contents/ui/configAppearance.qml ceb97326b8192a9dfe80b6753c0fd0a7e3010095 
>   applets/timer/package/contents/ui/timer.qml 82fee524f51f06f522fc8c556a7454ab6840d1a3 
> 
> Diff: https://git.reviewboard.kde.org/r/123332/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Appearance Config Ui (showing the defaults)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/11/7628230f-9be6-4c13-b57d-584cb56043bc__tab_appearance_default.png
> 
> 
> Thanks,
> 
> Bernhard Friedreich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150413/947ba3b7/attachment.html>