Review Request 123323: do not duplicate things done in the main cmake lists

David Edmundson david at davidedmundson.co.uk
Fri Apr 10 13:57:17 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123323/#review78766
-----------------------------------------------------------


The change is sensible, but doing this is problematic.

>cat README 

This is a COPY of the kactivities-stats library which resides in
kde:kactivities repo.

Anything you do here will be overwritten automatically by the code
from the aforementioned branch.

- David Edmundson


On April 10, 2015, 1:40 p.m., Harald Sitter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123323/
> -----------------------------------------------------------
> 
> (Updated April 10, 2015, 1:40 p.m.)
> 
> 
> Review request for Plasma and Ivan Čukić.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> do not duplicate things done in the main cmake lists
> 
> 
> Diffs
> -----
> 
>   lib/kactivities-stats/CMakeLists.txt 3d1b674591e8169a43df5440ca3525fa6b06ec94 
> 
> Diff: https://git.reviewboard.kde.org/r/123323/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Harald Sitter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150410/701feae0/attachment.html>


More information about the Plasma-devel mailing list