Review Request 123282: The energy info KCM

[Aleix Pol Gonzalez]

> On April 7, 2015, 3:45 p.m., Aleix Pol Gonzalez wrote:
> > Modules/energy/package/contents/ui/Graph.qml, line 94
> > <https://git.reviewboard.kde.org/r/123282/diff/1/?file=360361#file360361line94>
> >
> >     Is it fine to hardcode the colors?
> 
> David Edmundson wrote:
>     good question. I'm not sure what else we could use unless we start exporting kcolorscheme.

Then I'd say it's fine as long as the background is also hardcoded, at least for now?


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123282/#review78621
-----------------------------------------------------------


On April 7, 2015, 3:37 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123282/
> -----------------------------------------------------------
> 
> (Updated April 7, 2015, 3:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> -------
> 
> I assume everyone knows by now.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 139a49e 
>   Modules/CMakeLists.txt 37a1faf 
>   Modules/energy/CMakeLists.txt PRE-CREATION 
>   Modules/energy/Messages.sh PRE-CREATION 
>   Modules/energy/batterymodel.cpp PRE-CREATION 
>   Modules/energy/config-kcm.h.cmake PRE-CREATION 
>   Modules/energy/kcm.cpp PRE-CREATION 
>   Modules/energy/kcm_energyinfo.desktop PRE-CREATION 
>   Modules/energy/package/contents/ui/Graph.qml PRE-CREATION 
>   Modules/energy/package/contents/ui/main.qml PRE-CREATION 
>   Modules/energy/package/metadata.desktop PRE-CREATION 
>   Modules/energy/statisticsprovider.h PRE-CREATION 
>   Modules/energy/statisticsprovider.cpp PRE-CREATION 
>   Modules/energy/wakeupmodel.h PRE-CREATION 
>   Modules/energy/wakeupmodel.cpp PRE-CREATION 
>   ToolTips/ktooltipwindow_p.h 0813e6a 
>   ToolTips/ktooltipwindow_p.h 0813e6a 
>   infocenter.cpp 1ebbf71 
>   kcmcontainer.cpp c76ac65 
>   sidepanel.cpp f30ef4b 
> 
> Diff: https://git.reviewboard.kde.org/r/123282/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150408/91a7a720/attachment-0001.html>