Review Request 123282: The energy info KCM
Lukáš Tinkl
lukas at kde.org
Tue Apr 7 13:50:27 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123282/#review78622
-----------------------------------------------------------
Modules/energy/kcm.cpp (line 65)
<https://git.reviewboard.kde.org/r/123282/#comment53791>
No need to make your name translatable :p
Modules/energy/package/contents/ui/main.qml (line 97)
<https://git.reviewboard.kde.org/r/123282/#comment53798>
What about multiple batteries?
Modules/energy/package/contents/ui/main.qml (line 451)
<https://git.reviewboard.kde.org/r/123282/#comment53799>
Thi could really use some QLocale formatting of the number
Modules/energy/wakeupmodel.h (line 64)
<https://git.reviewboard.kde.org/r/123282/#comment53796>
override? (also below)
- Lukáš Tinkl
On Dub. 7, 2015, 3:37 odp., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123282/
> -----------------------------------------------------------
>
> (Updated Dub. 7, 2015, 3:37 odp.)
>
>
> Review request for Plasma.
>
>
> Repository: kinfocenter
>
>
> Description
> -------
>
> I assume everyone knows by now.
>
>
> Diffs
> -----
>
> CMakeLists.txt 139a49e
> Modules/CMakeLists.txt 37a1faf
> Modules/energy/CMakeLists.txt PRE-CREATION
> Modules/energy/Messages.sh PRE-CREATION
> Modules/energy/batterymodel.cpp PRE-CREATION
> Modules/energy/config-kcm.h.cmake PRE-CREATION
> Modules/energy/kcm.cpp PRE-CREATION
> Modules/energy/kcm_energyinfo.desktop PRE-CREATION
> Modules/energy/package/contents/ui/Graph.qml PRE-CREATION
> Modules/energy/package/contents/ui/main.qml PRE-CREATION
> Modules/energy/package/metadata.desktop PRE-CREATION
> Modules/energy/statisticsprovider.h PRE-CREATION
> Modules/energy/statisticsprovider.cpp PRE-CREATION
> Modules/energy/wakeupmodel.h PRE-CREATION
> Modules/energy/wakeupmodel.cpp PRE-CREATION
> ToolTips/ktooltipwindow_p.h 0813e6a
> ToolTips/ktooltipwindow_p.h 0813e6a
> infocenter.cpp 1ebbf71
> kcmcontainer.cpp c76ac65
> sidepanel.cpp f30ef4b
>
> Diff: https://git.reviewboard.kde.org/r/123282/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150407/422a898c/attachment.html>
More information about the Plasma-devel
mailing list