Review Request 123281: Avoid triggering bug 340691

Hrvoje Senjan hrvoje.senjan at gmail.com
Tue Apr 7 11:46:21 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123281/
-----------------------------------------------------------

(Updated April 7, 2015, 11:46 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin.


Changes
-------

Submitted with commit b2fc8174d5733fe3b051f839944870b4f51b8c52 by Hrvoje Senjan to branch master.


Repository: plasma-desktop


Description
-------

With Kdelibs4Migration we know exactly which file to modify, so it is both correct to use KConfig::SimpleConfig, and should help avoiding triggering the mentioned bug.
As similar fix was applied for bug 343583.


Diffs
-----

  kcms/icons/icons.cpp 16a3141 
  kcms/migrationlib/kdelibs4config.h 0c1b7fe 

Diff: https://git.reviewboard.kde.org/r/123281/diff/


Testing
-------

Changed the default browser in systemsettings5, the config got written in both ~/.config/kdeglobals and ~/.kde4/share/config/kdeglobals


Thanks,

Hrvoje Senjan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150407/579ca2bd/attachment.html>


More information about the Plasma-devel mailing list