Review Request 123281: Avoid triggering bug 340691

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123281/#review78614
-----------------------------------------------------------

Ship it!


Ship It!

- Marco Martin


On April 7, 2015, 11:13 a.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123281/
> -----------------------------------------------------------
> 
> (Updated April 7, 2015, 11:13 a.m.)
> 
> 
> Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> With Kdelibs4Migration we know exactly which file to modify, so it is both correct to use KConfig::SimpleConfig, and should help avoiding triggering the mentioned bug.
> As similar fix was applied for bug 343583.
> 
> 
> Diffs
> -----
> 
>   kcms/icons/icons.cpp 16a3141 
>   kcms/migrationlib/kdelibs4config.h 0c1b7fe 
> 
> Diff: https://git.reviewboard.kde.org/r/123281/diff/
> 
> 
> Testing
> -------
> 
> Changed the default browser in systemsettings5, the config got written in both ~/.config/kdeglobals and ~/.kde4/share/config/kdeglobals
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150407/68d3d1b4/attachment-0001.html>