Review Request 117681: showdesktop plasma addon: Add option to restrict size on large panels

Gregor Mi codestruct at posteo.org
Sat Apr 4 16:13:40 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117681/
-----------------------------------------------------------

(Updated April 4, 2015, 4:13 p.m.)


Status
------

This change has been discarded.


Review request for Plasma, Dominik Haumann and Sebastian K├╝gler.


Repository: kdeplasma-addons


Description
-------

This adds the option "Restrict size on large panels" (taken from https://git.reviewboard.kde.org/r/117041/) to the showdesktop plasma applet.

I am aware that c++ applets will go away in favour of QML based ones with plasma 2. So this review request is meant for discussion and to settle the code base of the extended behaviour before the porting to QML starts.

Detailed changes:
- fix compiler warning in sizeHint(...)
- add "General" config page to applet settings
  - implement "Restrict size on large panels" (and reformat source file showdesktop.h)
- add .reviewboardrc
- add .gitignore to ignore build and development files


Diffs
-----

  .gitignore PRE-CREATION 
  .reviewboardrc PRE-CREATION 
  applets/showdesktop/CMakeLists.txt eb532075cbe8ff734bebdfc8d35af7e9e9f5c32d 
  applets/showdesktop/showdesktop.h 5aeb8481df824f6ea9d7969cf544876f5fb3473c 
  applets/showdesktop/showdesktop.cpp d712519918fcf2efe4dbbb5337a29316d53e759a 
  applets/showdesktop/showdesktopConfig.ui PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/117681/diff/


Testing
-------

yes, using plasmoidviewer


Thanks,

Gregor Mi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150404/e70425e0/attachment.html>


More information about the Plasma-devel mailing list