<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117681/">https://git.reviewboard.kde.org/r/117681/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Dominik Haumann and Sebastian Kügler.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated April 4, 2015, 4:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds the option "Restrict size on large panels" (taken from https://git.reviewboard.kde.org/r/117041/) to the showdesktop plasma applet.
I am aware that c++ applets will go away in favour of QML based ones with plasma 2. So this review request is meant for discussion and to settle the code base of the extended behaviour before the porting to QML starts.
Detailed changes:
- fix compiler warning in sizeHint(...)
- add "General" config page to applet settings
- implement "Restrict size on large panels" (and reformat source file showdesktop.h)
- add .reviewboardrc
- add .gitignore to ignore build and development files
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">yes, using plasmoidviewer</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>.gitignore <span style="color: grey">(PRE-CREATION)</span></li>
<li>.reviewboardrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>applets/showdesktop/CMakeLists.txt <span style="color: grey">(eb532075cbe8ff734bebdfc8d35af7e9e9f5c32d)</span></li>
<li>applets/showdesktop/showdesktop.h <span style="color: grey">(5aeb8481df824f6ea9d7969cf544876f5fb3473c)</span></li>
<li>applets/showdesktop/showdesktop.cpp <span style="color: grey">(d712519918fcf2efe4dbbb5337a29316d53e759a)</span></li>
<li>applets/showdesktop/showdesktopConfig.ui <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117681/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>