Review Request 123211: Ask for confirmation before deleting a wallpaper.

[Antonis Tsiapaliokas]

> On April 3, 2015, 3:13 p.m., Thomas Pfeiffer wrote:
> > It's great that you've implemented the undo function, awesome!
> > What I cannot really tell from the screenshots is how a wallpaper which is marked to be removed is visualized. Can you maybe add a screenshot where the distinction between those which are marked for removal and those which are not becomes clear?
> > Thanks!

I have add a new screenshot. 
The wallpaper with the kde forums is currenty being marked for deletion, 
while the one with the bugzilla it is not being marked for deletion.

The basic difference between the deleted and the non deleted is that i add opacity.
So the one which is going to be deleted is shown up as faded out..

I am pushing this patch as is for now. If you have any better ideas, about how we could
archive a better distinction between these two, let me know.


- Antonis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123211/#review78441
-----------------------------------------------------------


On April 3, 2015, 3:58 p.m., Antonis Tsiapaliokas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123211/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 3:58 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 338729
>     https://bugs.kde.org/show_bug.cgi?id=338729
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch is adding a confirmation dialog which is being called before we remove a wallpaper.
> 
> 
> Diffs
> -----
> 
>   wallpapers/image/backgroundlistmodel.h 01b528d 
>   wallpapers/image/backgroundlistmodel.cpp d062650 
>   wallpapers/image/image.h a00e431 
>   wallpapers/image/image.cpp f0c672a 
>   wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml aee2d3f 
>   wallpapers/image/imagepackage/contents/ui/config.qml 2108082 
> 
> Diff: https://git.reviewboard.kde.org/r/123211/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> dialog
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/01/5bfd2d7c-8baa-4b80-ad20-0844aafdb3a9__deletion_dialog.png
> wallpaper remove
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/8acc3dab-4c2a-4cc2-9ba3-9893e42c32d3__wallpaper_undo.png
> wallpaper restore
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/4b23e100-194a-4557-926c-d7af252f15d7__wallpaper_undo3.png
> 1st_is_removed_2nd_isnt
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/04/03/84e524f9-7875-42b2-ad8c-3083b7e0bd22__1st_wallapper_is_removed_the_2nd_isnt.png
> 
> 
> Thanks,
> 
> Antonis Tsiapaliokas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150403/9880315f/attachment-0001.html>