<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123211/">https://git.reviewboard.kde.org/r/123211/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 3rd, 2015, 3:13 p.m. UTC, <b>Thomas Pfeiffer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's great that you've implemented the undo function, awesome!
What I cannot really tell from the screenshots is how a wallpaper which is marked to be removed is visualized. Can you maybe add a screenshot where the distinction between those which are marked for removal and those which are not becomes clear?
Thanks!</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have add a new screenshot.
The wallpaper with the kde forums is currenty being marked for deletion,
while the one with the bugzilla it is not being marked for deletion.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The basic difference between the deleted and the non deleted is that i add opacity.
So the one which is going to be deleted is shown up as faded out..</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I am pushing this patch as is for now. If you have any better ideas, about how we could
archive a better distinction between these two, let me know.</p></pre>
<br />
<p>- Antonis</p>
<br />
<p>On April 3rd, 2015, 3:58 p.m. UTC, Antonis Tsiapaliokas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma.</div>
<div>By Antonis Tsiapaliokas.</div>
<p style="color: grey;"><i>Updated April 3, 2015, 3:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=338729">338729</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch is adding a confirmation dialog which is being called before we remove a wallpaper.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>wallpapers/image/backgroundlistmodel.h <span style="color: grey">(01b528d)</span></li>
<li>wallpapers/image/backgroundlistmodel.cpp <span style="color: grey">(d062650)</span></li>
<li>wallpapers/image/image.h <span style="color: grey">(a00e431)</span></li>
<li>wallpapers/image/image.cpp <span style="color: grey">(f0c672a)</span></li>
<li>wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml <span style="color: grey">(aee2d3f)</span></li>
<li>wallpapers/image/imagepackage/contents/ui/config.qml <span style="color: grey">(2108082)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123211/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/01/5bfd2d7c-8baa-4b80-ad20-0844aafdb3a9__deletion_dialog.png">dialog</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/8acc3dab-4c2a-4cc2-9ba3-9893e42c32d3__wallpaper_undo.png">wallpaper remove</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/02/4b23e100-194a-4557-926c-d7af252f15d7__wallpaper_undo3.png">wallpaper restore</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/03/84e524f9-7875-42b2-ad8c-3083b7e0bd22__1st_wallapper_is_removed_the_2nd_isnt.png">1st_is_removed_2nd_isnt</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>