Review Request 123190: CMakeLists.txt: Install sddm theme to KDE_INSTALL_DATADIR

David Edmundson david at davidedmundson.co.uk
Thu Apr 2 21:48:53 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123190/#review78423
-----------------------------------------------------------



CMakeLists.txt (line 122)
<https://git.reviewboard.kde.org/r/123190/#comment53659>

    make it CMAKE_INSTALL_FULL_DATADIR_DATADIR
    
    so it's always absolute.


As long as there isn't a possibility that this will end up in a different directory to main SDDM themes because of this, ship it.

- David Edmundson


On March 31, 2015, 12:02 a.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123190/
> -----------------------------------------------------------
> 
> (Updated March 31, 2015, 12:02 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This allows installing the sddm theme to a datadir which is outside of the prefix, for example on a multiarch layout where arch specific stuff goes to /usr/${host}/blah but arch independent stuff still to /usr/share.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 40350b2 
> 
> Diff: https://git.reviewboard.kde.org/r/123190/diff/
> 
> 
> Testing
> -------
> 
> Built and installed to the configured location.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150402/2c73d40b/attachment.html>


More information about the Plasma-devel mailing list