Review Request 123164: Add new Bluetooth applet

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/
-----------------------------------------------------------

(Updated April 2, 2015, 10:13 a.m.)


Review request for Bluedevil and Plasma.


Changes
-------

I've added a new state when Bluetooth is blocked with rfkill.

If there are no more code issues, I will push it. UI issues can be fixed later with feedback from users.


Repository: bluedevil


Description
-------

This is a replacement for bluedevil-monolithic.
The code is based on network management plasmoid and it does basically the same but for Bluetooth devices.


Diffs (updated)
-----

  CMakeLists.txt 94b56fb 
  src/CMakeLists.txt b804f2b 
  src/applet/CMakeLists.txt PRE-CREATION 
  src/applet/Messages.sh PRE-CREATION 
  src/applet/package/contents/code/logic.js PRE-CREATION 
  src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION 
  src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION 
  src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION 
  src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION 
  src/applet/package/contents/ui/Header.qml PRE-CREATION 
  src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION 
  src/applet/package/contents/ui/Toolbar.qml PRE-CREATION 
  src/applet/package/metadata.desktop PRE-CREATION 
  src/applet/plugin/CMakeLists.txt PRE-CREATION 
  src/applet/plugin/bluetoothplugin.h PRE-CREATION 
  src/applet/plugin/bluetoothplugin.cpp PRE-CREATION 
  src/applet/plugin/devicesproxymodel.h PRE-CREATION 
  src/applet/plugin/devicesproxymodel.cpp PRE-CREATION 
  src/applet/plugin/launchapp.h PRE-CREATION 
  src/applet/plugin/launchapp.cpp PRE-CREATION 
  src/applet/plugin/notify.h PRE-CREATION 
  src/applet/plugin/notify.cpp PRE-CREATION 
  src/applet/plugin/qmldir PRE-CREATION 
  src/bluedevil.notifyrc f87dc95 

Diff: https://git.reviewboard.kde.org/r/123164/diff/


Testing
-------

I've been running it for some time already and it works fine.


File Attachments
----------------

snapshot4.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
snapshot5.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
btapplet6.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/d8ffae3d-f4f4-4bf1-b5ad-27d1298d4d3f__btapplet6.png
btapplet7.png
  https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/957074cc-acf4-40b1-bb08-857ac6937669__btapplet7.png


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150402/0e445266/attachment-0001.html>