Review Request 123220: kfontinst: Fix font list view header alignment and item sizehint

Daniel Vrátil dvratil at
Thu Apr 2 09:49:02 UTC 2015

This is an automatically generated e-mail. To reply, visit:

(Updated April 2, 2015, 9:49 a.m.)


This change has been marked as submitted.

Review request for Plasma.


Submitted with commit a385460fc2a2ccec70f00bcc5ab51d4d648904e1 by Dan Vrátil to branch master.

Repository: plasma-desktop


I'm not sure the Qt::TextAlignmentRole is even needed (I think it would be better if the KCM obeyed whathever is the current theme default), but it should at least be centered vertically. I guess this wasn't so obvious with Oxygen, but Breeze makes the missing vertical alignment really obvious.

For the SizeHint role, relying on size of a particular random icon if we have a standard method for retrieving default icon size sounds wrong to me. For some reason my system refuses to load dialog-ok icon (so SmallIcon("dialog-ok").size() was returning QSize(0, 0)), which caused all items in the view to have SizeHint QSize(0, 4), making it KCM basically unusable.


  kcms/kfontinst/kcmfontinst/FontList.cpp 802b383 
  kcms/kfontinst/kcmfontinst/GroupList.cpp 4532c0d 




Daniel Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the Plasma-devel mailing list