Review Request 123213: Add an option to enable/disable the blue focus highlight on frames

[Hugo Pereira Da Costa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123213/#review78355
-----------------------------------------------------------


Hi David, 
What's the rationale behind this option ? How do you indicate focus (and mouseover) in e.g. editors, when this option is checked ? Doesn't that explicitly break usability ? If yes, I'd be reluctant to add an option that does just that, unless you have a specific use-case in mind of course.
(this would open the door to options like "disable button-press feedback, checkbox marks, etc. :))

Also, (as was already answered in an older review request if I remember right), I in general would rather avoid adding new options, and changing the design, for oxygen, in KF5 times, since it is not the default theme any more, can largely be considered as "done" (IMHO), and in "maintenance" mode, with bugfixing commits going in only. (but that is just a personal oppinion of course).

- Hugo Pereira Da Costa


On April 1, 2015, 4:08 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123213/
> -----------------------------------------------------------
> 
> (Updated April 1, 2015, 4:08 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: oxygen
> 
> 
> Description
> -------
> 
> Add an option to enable/disable the blue focus highlight on frames
> Defaults are unchanged
> 
> 
> Diffs
> -----
> 
>   kstyle/config/oxygenstyleconfig.cpp 116697c 
>   kstyle/config/ui/oxygenstyleconfig.ui 6f48fd2 
>   kstyle/oxygen.kcfg b3551cc 
>   kstyle/oxygenstyle.cpp b7f392d 
> 
> Diff: https://git.reviewboard.kde.org/r/123213/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150401/2fac4df6/attachment.html>