<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123213/">https://git.reviewboard.kde.org/r/123213/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi David,
What's the rationale behind this option ? How do you indicate focus (and mouseover) in e.g. editors, when this option is checked ? Doesn't that explicitly break usability ? If yes, I'd be reluctant to add an option that does just that, unless you have a specific use-case in mind of course.
(this would open the door to options like "disable button-press feedback, checkbox marks, etc. :))</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, (as was already answered in an older review request if I remember right), I in general would rather avoid adding new options, and changing the design, for oxygen, in KF5 times, since it is not the default theme any more, can largely be considered as "done" (IMHO), and in "maintenance" mode, with bugfixing commits going in only. (but that is just a personal oppinion of course).</p></pre>
<br />
<p>- Hugo Pereira Da Costa</p>
<br />
<p>On April 1st, 2015, 4:08 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Hugo Pereira Da Costa.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated April 1, 2015, 4:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
oxygen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add an option to enable/disable the blue focus highlight on frames
Defaults are unchanged</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstyle/config/oxygenstyleconfig.cpp <span style="color: grey">(116697c)</span></li>
<li>kstyle/config/ui/oxygenstyleconfig.ui <span style="color: grey">(6f48fd2)</span></li>
<li>kstyle/oxygen.kcfg <span style="color: grey">(b3551cc)</span></li>
<li>kstyle/oxygenstyle.cpp <span style="color: grey">(b7f392d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123213/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>