Review Request 120419: [ksmserver] Get rid of KDELibs4Support...

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120419/#review67620
-----------------------------------------------------------

Ship it!


Looks good. Maybe you want to use qCDebug, but it's a little bit of a pain, and from what I remember Alex had mentioned that he wants to get rid of these debug messages anyway. Perhaps you can ask him which he prefers?

Getting rid of KDELibs4Support will improve bootup time to a certain extent. We had done some basic benchmarks once, and the loading of KDELibs4Support was making a difference.

- Vishesh Handa


On Sept. 29, 2014, 10:50 a.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120419/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2014, 10:50 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> ...as much as possible. still left some Solid usage.
> 
> 
> Diffs
> -----
> 
>   ksmserver/CMakeLists.txt 49870fb 
>   ksmserver/client.cpp 6232d71 
>   ksmserver/legacy.cpp bb102a8 
>   ksmserver/main.cpp 75ca468 
>   ksmserver/server.cpp a2cd6e6 
>   ksmserver/shutdown.cpp b67a6a9 
>   ksmserver/shutdowndlg.cpp 5c484f3 
>   ksmserver/startup.cpp a173237 
> 
> Diff: https://git.reviewboard.kde.org/r/120419/diff/
> 
> 
> Testing
> -------
> 
> starting/shutdown, restoring session/clean session all seem to work
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140929/e13e7af2/attachment.html>