Review Request 120419: [ksmserver] Get rid of KDELibs4Support...

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120419/#review67619
-----------------------------------------------------------



ksmserver/legacy.cpp
<https://git.reviewboard.kde.org/r/120419/#comment47124>

    Maybe qCDebug?


Other than that it's fine. Good work!

We should find a solution for the Solid/PowerManagement part...

- Aleix Pol Gonzalez


On Sept. 29, 2014, 10:50 a.m., Hrvoje Senjan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120419/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2014, 10:50 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> ...as much as possible. still left some Solid usage.
> 
> 
> Diffs
> -----
> 
>   ksmserver/CMakeLists.txt 49870fb 
>   ksmserver/client.cpp 6232d71 
>   ksmserver/legacy.cpp bb102a8 
>   ksmserver/main.cpp 75ca468 
>   ksmserver/server.cpp a2cd6e6 
>   ksmserver/shutdown.cpp b67a6a9 
>   ksmserver/shutdowndlg.cpp 5c484f3 
>   ksmserver/startup.cpp a173237 
> 
> Diff: https://git.reviewboard.kde.org/r/120419/diff/
> 
> 
> Testing
> -------
> 
> starting/shutdown, restoring session/clean session all seem to work
> 
> 
> Thanks,
> 
> Hrvoje Senjan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140929/18dc28cf/attachment-0001.html>