Review Request 120327: Fix crash in ImageWallpaper

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120327/
-----------------------------------------------------------

(Updated Sept. 25, 2014, 2:43 p.m.)


Status
------

This change has been discarded.


Review request for Plasma.


Repository: plasma-workspace


Description
-------

Fix crash in ImageWallpaper

When not in a package (i.e a lone image) the metadata file cannot be
loaded. This returns an invalid metadata (KPluginInfo) with isValid()
set to false but an invalid d pointer.


Diffs
-----

  wallpapers/image/backgroundlistmodel.cpp a667c10 

Diff: https://git.reviewboard.kde.org/r/120327/diff/


Testing
-------

In config to change the wallpaper click the remove button of one of your own images, it didn't crash.

It fixes it, but I'm not convinced it's the correct fix, we're still spewing warnings about the package being broken.


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140925/269435ad/attachment.html>