Review Request 120327: Fix crash in ImageWallpaper

[David Edmundson]

> On Sept. 23, 2014, 8:08 a.m., Marco Martin wrote:
> > wallpapers/image/backgroundlistmodel.cpp, line 377
> > <https://git.reviewboard.kde.org/r/120327/diff/1/?file=314655#file314655line377>
> >
> >     hmm, this way you are saying 
> >     if the package b is not valid, then try to access its metadata.
> >     doesn't look correct..

er yeah. I'm not sure what I was thinking...Thanks.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120327/#review67270
-----------------------------------------------------------


On Sept. 22, 2014, 11:38 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120327/
> -----------------------------------------------------------
> 
> (Updated Sept. 22, 2014, 11:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Fix crash in ImageWallpaper
> 
> When not in a package (i.e a lone image) the metadata file cannot be
> loaded. This returns an invalid metadata (KPluginInfo) with isValid()
> set to false but an invalid d pointer.
> 
> 
> Diffs
> -----
> 
>   wallpapers/image/backgroundlistmodel.cpp a667c10 
> 
> Diff: https://git.reviewboard.kde.org/r/120327/diff/
> 
> 
> Testing
> -------
> 
> In config to change the wallpaper click the remove button of one of your own images, it didn't crash.
> 
> It fixes it, but I'm not convinced it's the correct fix, we're still spewing warnings about the package being broken.
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140925/2bd06ef4/attachment-0001.html>