Review Request 120316: standalone application mode for plasmashell

[Marco Martin]

> On Sept. 23, 2014, 10:46 a.m., David Edmundson wrote:
> > shell/main.cpp, line 134
> > <https://git.reviewboard.kde.org/r/120316/diff/4/?file=314790#file314790line134>
> >
> >     do standalone shells need to respawn?

hmm, indeed since is not using shellmanager, it wouldn't even work (and no, doesn't need it)


> On Sept. 23, 2014, 10:46 a.m., David Edmundson wrote:
> > shell/standaloneappcorona.cpp, line 168
> > <https://git.reviewboard.kde.org/r/120316/diff/4/?file=314797#file314797line168>
> >
> >     why do this when we change activity?

because you don't know if that containment is an old one or has been created from scratch, if that's the latter case, the remove action needs to be removed.


> On Sept. 23, 2014, 10:46 a.m., David Edmundson wrote:
> > shell/desktopview.cpp, line 215
> > <https://git.reviewboard.kde.org/r/120316/diff/4/?file=314789#file314789line215>
> >
> >     why do we have to do this on every focus event when we didn't when it was the 3 booleans?

i'm not sure why it doesn't work :/
it seems the fullscreen flag has to be set a bit after the window has been shown, or kwin seem to ignore it :/


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120316/#review67282
-----------------------------------------------------------


On Sept. 23, 2014, 10:29 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120316/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2014, 10:29 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This is as alternative to https://git.reviewboard.kde.org/r/120270/
> 
> with this approach it becomes possible for the applications to use scripting, even tough makes shellcorona even more complicated.
> It also introduces a little change in the api between Desktop.qml and desktopview.cpp that i think it makes sense regardless of the other components of the patch (and that should really go in before thursday).
> 
> One thing I still think I'll try is to use another corona in this case (basically simpleshellcorona from the other review request) so it does not make the code of shellcorona more complex (but will make scripting a bit more complicated)
> 
> 
> Diffs
> -----
> 
>   shell/CMakeLists.txt e835bf8 
>   shell/desktopview.h 6aeeeb6 
>   shell/desktopview.cpp 08c1c32 
>   shell/main.cpp e737007 
>   shell/scripting/scriptengine.h 6ce8b51 
>   shell/scripting/scriptengine.cpp 5b035ea 
>   shell/shellcorona.cpp eeb01af 
>   shell/shellmanager.h eef25aa 
>   shell/shellmanager.cpp f6472cb 
>   shell/standaloneappcorona.h PRE-CREATION 
>   shell/standaloneappcorona.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120316/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140923/2d7b404c/attachment-0001.html>