Review Request 120316: standalone application mode for plasmashell

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120316/#review67282
-----------------------------------------------------------



shell/desktopview.cpp
<https://git.reviewboard.kde.org/r/120316/#comment46975>

    why do we have to do this on every focus event when we didn't when it was the 3 booleans?



shell/desktopview.cpp
<https://git.reviewboard.kde.org/r/120316/#comment46972>

    would probably be best to do 
    
    if (!standalone) {
     e->ignore();
    }
    
    otherwise let the event propogate, rather than having direct handling for both things.



shell/main.cpp
<https://git.reviewboard.kde.org/r/120316/#comment46974>

    do standalone shells need to respawn?



shell/main.cpp
<https://git.reviewboard.kde.org/r/120316/#comment46973>

    why not just create it on the stack and remove the delete.
    Failing that use QScopedPointer



shell/standaloneappcorona.cpp
<https://git.reviewboard.kde.org/r/120316/#comment46971>

    why do this when we change activity?


- David Edmundson


On Sept. 23, 2014, 10:29 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120316/
> -----------------------------------------------------------
> 
> (Updated Sept. 23, 2014, 10:29 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This is as alternative to https://git.reviewboard.kde.org/r/120270/
> 
> with this approach it becomes possible for the applications to use scripting, even tough makes shellcorona even more complicated.
> It also introduces a little change in the api between Desktop.qml and desktopview.cpp that i think it makes sense regardless of the other components of the patch (and that should really go in before thursday).
> 
> One thing I still think I'll try is to use another corona in this case (basically simpleshellcorona from the other review request) so it does not make the code of shellcorona more complex (but will make scripting a bit more complicated)
> 
> 
> Diffs
> -----
> 
>   shell/CMakeLists.txt e835bf8 
>   shell/desktopview.h 6aeeeb6 
>   shell/desktopview.cpp 08c1c32 
>   shell/main.cpp e737007 
>   shell/scripting/scriptengine.h 6ce8b51 
>   shell/scripting/scriptengine.cpp 5b035ea 
>   shell/shellcorona.cpp eeb01af 
>   shell/shellmanager.h eef25aa 
>   shell/shellmanager.cpp f6472cb 
>   shell/standaloneappcorona.h PRE-CREATION 
>   shell/standaloneappcorona.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120316/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140923/4bc2cbd8/attachment-0001.html>