Review Request 120284: sanity checking in desktops/activities scripting

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120284/
-----------------------------------------------------------

(Updated Sept. 19, 2014, 1:19 p.m.)


Review request for Plasma.


Changes
-------

and one more bonus fix: checking the name of the shell binary when loading a template no longer makes any sense so just get rid of that as well. plugin name namespacing can be 'abused' in future for a similar effect to what this was doing in plasma 4.x if needed.


Repository: plasma-workspace


Description
-------

This patch set

* checks that there are desktops for a given activity; happens when activities exist and a new shell config is being made
* checks that an activity actually exists before handing out containments for it
* allow fetching the current activity


Diffs (updated)
-----

  shell/scripting/scriptengine.h 2ea0e3170e2388780ea36eefdf58caf64afbb0cb 
  shell/scripting/scriptengine.cpp f458becb5df33116a6251ba3876aa6e06d16e2bf 
  shell/shellcorona.h 84919ff4ca22b9e481aa5719e28a664da0f2f9d1 
  shell/desktopview.cpp 2df96b94bb924251bb7023149cc11cb1bc7dba8e 

Diff: https://git.reviewboard.kde.org/r/120284/diff/


Testing
-------

Ran plasmashell and a layout.js that was failing due to the above issues.


Thanks,

Aaron J. Seigo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140919/830b62c7/attachment.html>