Review Request 120284: sanity checking in desktops/activities scripting

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120284/#review66950
-----------------------------------------------------------

Ship it!


Good catch, just a detail I would do differently.


shell/scripting/scriptengine.cpp
<https://git.reviewboard.kde.org/r/120284/#comment46706>

    in the end would be the same, but I would use Corona::numScreens instead
    (if I'll end up using scripting for single window apps like plasma mediacenter in plasma-windowed, this code would work also for coronas that report a number of screens different than the real one)


- Marco Martin


On Sept. 19, 2014, 12:37 p.m., Aaron J. Seigo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120284/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 12:37 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This patch set
> 
> * checks that there are desktops for a given activity; happens when activities exist and a new shell config is being made
> * checks that an activity actually exists before handing out containments for it
> * allow fetching the current activity
> 
> 
> Diffs
> -----
> 
>   shell/scripting/scriptengine.h 2ea0e3170e2388780ea36eefdf58caf64afbb0cb 
>   shell/scripting/scriptengine.cpp f458becb5df33116a6251ba3876aa6e06d16e2bf 
>   shell/shellcorona.h 84919ff4ca22b9e481aa5719e28a664da0f2f9d1 
> 
> Diff: https://git.reviewboard.kde.org/r/120284/diff/
> 
> 
> Testing
> -------
> 
> Ran plasmashell and a layout.js that was failing due to the above issues.
> 
> 
> Thanks,
> 
> Aaron J. Seigo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140919/a1e12a1d/attachment.html>