Review Request 120270: full shell mode for plasma-windowed

[Marco Martin]

> On Sept. 19, 2014, 4:30 a.m., Bhushan Shah wrote:
> > plasma-windowed/simpleshellview.cpp, line 36
> > <https://git.reviewboard.kde.org/r/120270/diff/1/?file=313276#file313276line36>
> >
> >     This should come from arguments maybe? and should not be Plasma mediacenter obviously.. :p

eww, forgot it, right. It should come form the metadata


> On Sept. 19, 2014, 4:30 a.m., Bhushan Shah wrote:
> > plasma-windowed/main.cpp, line 101
> > <https://git.reviewboard.kde.org/r/120270/diff/1/?file=313270#file313270line101>
> >
> >     Can't we have it non-unique? I mean like if one have other application then plasma-mediacenter, plasma-myawesomeapplication.. he will not be able to run it if pmc is running? or maybe I am missing something here completely..

it should be fine.
it should create one corona and one view per shell in this case (the unique dbus name contains the shell plugin, so there will be one dbus adress per corona).
it's unique to avoid having two with both palsma-mediacenter (in which case it may create inconsistencies in the config file)


> On Sept. 19, 2014, 4:30 a.m., Bhushan Shah wrote:
> > plasma-windowed/simpleshellcorona.cpp, line 99
> > <https://git.reviewboard.kde.org/r/120270/diff/1/?file=313274#file313274line99>
> >
> >     this was case only for PMC IIRC, maybe evaluate layout.js of shell package here?

Yes, the correct way should be to integrate shell scripring.
It's a bit ugly since it would have to statically link to it including relative paths, but that's fine, so I'll try that


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120270/#review66900
-----------------------------------------------------------


On Sept. 18, 2014, 6:33 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120270/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2014, 6:33 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> this adds an option to plasma-windowed to run a shell package together with a containment in its own window/process.
> it's intended for full applications done just in qml that want to host widgets as well, like plasma-mediacenter.
> This is part of getting all the needed shells in the same place, so they will be able to return in plasma-framework and the libplasmaquick library not be exported anymore
> 
> 
> Diffs
> -----
> 
>   plasma-windowed/CMakeLists.txt 252724a 
>   plasma-windowed/main.cpp 649bd39 
>   plasma-windowed/plasmawindowedcorona.h 8e6fd76 
>   plasma-windowed/plasmawindowedcorona.cpp 3dee283 
>   plasma-windowed/simpleshellcorona.h PRE-CREATION 
>   plasma-windowed/simpleshellcorona.cpp PRE-CREATION 
>   plasma-windowed/simpleshellview.h PRE-CREATION 
>   plasma-windowed/simpleshellview.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120270/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140919/ddc3b396/attachment.html>