Review Request 120270: full shell mode for plasma-windowed

[Bhushan Shah]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120270/#review66900
-----------------------------------------------------------



plasma-windowed/main.cpp
<https://git.reviewboard.kde.org/r/120270/#comment46655>

    Can't we have it non-unique? I mean like if one have other application then plasma-mediacenter, plasma-myawesomeapplication.. he will not be able to run it if pmc is running? or maybe I am missing something here completely..



plasma-windowed/simpleshellcorona.cpp
<https://git.reviewboard.kde.org/r/120270/#comment46654>

    this was case only for PMC IIRC, maybe evaluate layout.js of shell package here?



plasma-windowed/simpleshellview.cpp
<https://git.reviewboard.kde.org/r/120270/#comment46653>

    This should come from arguments maybe? and should not be Plasma mediacenter obviously.. :p


- Bhushan Shah


On Sept. 19, 2014, 12:03 a.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120270/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2014, 12:03 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> this adds an option to plasma-windowed to run a shell package together with a containment in its own window/process.
> it's intended for full applications done just in qml that want to host widgets as well, like plasma-mediacenter.
> This is part of getting all the needed shells in the same place, so they will be able to return in plasma-framework and the libplasmaquick library not be exported anymore
> 
> 
> Diffs
> -----
> 
>   plasma-windowed/CMakeLists.txt 252724a 
>   plasma-windowed/main.cpp 649bd39 
>   plasma-windowed/plasmawindowedcorona.h 8e6fd76 
>   plasma-windowed/plasmawindowedcorona.cpp 3dee283 
>   plasma-windowed/simpleshellcorona.h PRE-CREATION 
>   plasma-windowed/simpleshellcorona.cpp PRE-CREATION 
>   plasma-windowed/simpleshellview.h PRE-CREATION 
>   plasma-windowed/simpleshellview.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120270/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140919/37a0ed10/attachment.html>