Review Request 120248: Override the implicitSizes in the ruler completley

[David Edmundson]

> On Sept. 17, 2014, 6:35 p.m., Marco Martin wrote:
> > hmm, not sure is the correct way, setting implicitsizes should be expected to work correctly and not be rewrittten by the component.
> > 
> > maybe it should check at componentcomplete if at that point impolicitWidth has been set by the user
> 
> David Edmundson wrote:
>     I think your patch was right. Consider a Text Item. The implicitSize changes whenever the text changes.
> 
> Marco Martin wrote:
>     perhaps.. so it should be as Text, implicitWidth/height become read only, to give an error if the user tries to write the proeprties
> 
> David Edmundson wrote:
>     Ooh, so it is. That approach makes sense.
>     ++
> 
> Marco Martin wrote:
>     to recap:
>     * my original patch to be restored
>     * implicitWidth/height readonly properties
>     * this patch goes in

I think that's how things should end up.

But if we do that now in Frameworks 5.3 we break the panel explorer even loading for a week before workspace 5.1 comes out :(

(these staggered releases suck)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120248/#review66766
-----------------------------------------------------------


On Sept. 17, 2014, 6:22 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120248/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2014, 6:22 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Override the implicitSizes in the ruler completley
> 
> Needed to fix: https://gerrit.vesnicky.cesnet.cz/r/#/c/41/2
> Though I think that change was correct (and so is this one)
> 
> 
> Diffs
> -----
> 
>   desktoppackage/contents/configuration/panelconfiguration/Ruler.qml 6cdccc9 
> 
> Diff: https://git.reviewboard.kde.org/r/120248/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140917/fc6c18bf/attachment.html>