Review Request 120179: return correct screen() even when we are still starting up

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120179/#review66550
-----------------------------------------------------------



shell/shellcorona.cpp
<https://git.reviewboard.kde.org/r/120179/#comment46388>

    this comment is ambigous which ends up not helping.
    
    I read this as:
    
    correct screen for (panels and for desktops) that have the same activity 
    
    Whereas I now assume it's:
    
    correct screen for panels and for (desktops that have the same activity )



shell/shellcorona.cpp
<https://git.reviewboard.kde.org/r/120179/#comment46387>

    containment->containmentType() == Plasma::Types::PanelContainment
    
    ||
    
    containment->containmentType() == Plasma::Types::PanelContainment
    
    This says the same thing twice?


- David Edmundson


On Sept. 15, 2014, 12:31 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120179/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2014, 12:31 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> If screenForContainment() depends on the existence of the view instance, while the corona is starting up, screen() will return -1 for a while, changing the behavior depending where is called.
> 
> this patch makes screen() return a stable final value, even before any view has been created.
> this is (also) needed for correctly keeping track of what containments are still loading, what finished.
> 
> 
> Diffs
> -----
> 
>   shell/shellcorona.cpp 081a1ad 
> 
> Diff: https://git.reviewboard.kde.org/r/120179/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140915/73525181/attachment.html>