Review Request 120179: return correct screen() even when we are still starting up
Marco Martin
notmart at gmail.com
Mon Sep 15 12:31:09 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120179/
-----------------------------------------------------------
(Updated Sept. 15, 2014, 12:31 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Repository: plasma-workspace
Description
-------
If screenForContainment() depends on the existence of the view instance, while the corona is starting up, screen() will return -1 for a while, changing the behavior depending where is called.
this patch makes screen() return a stable final value, even before any view has been created.
this is (also) needed for correctly keeping track of what containments are still loading, what finished.
Diffs
-----
shell/shellcorona.cpp 081a1ad
Diff: https://git.reviewboard.kde.org/r/120179/diff/
Testing
-------
Thanks,
Marco Martin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140915/3dd9d55e/attachment.html>
More information about the Plasma-devel
mailing list