Review Request 119920: Restore original checkbox and radio button size

Sat Sep 6 12:38:06 UTC 2014

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119920/
-----------------------------------------------------------

(Updated Sept. 6, 2014, 12:38 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: plasma-framework

Description
-------

This patch restores the original checkbox and radio button size calculation as it was before the migration to QtQuick Controls.

On one hand the newer, smaller one size-wise looks closer to the one used in Widget/Desktop-style apps but eg. battery monitor looks weird with the smaller one.

Diffs
-----

  src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml d9dc9fd 
  src/declarativeimports/plasmacomponents/qml/styles/RadioButtonStyle.qml 6d06f01 

Diff: https://git.reviewboard.kde.org/r/119920/diff/

Testing
-------

CheckBox looks like it did before, did not test Radio Button, in Radio Button it also does away with the hardcoded 6px margin used previously.

Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140906/cd01c327/attachment.html>