Review Request 119920: Restore original checkbox and radio button size

[David Edmundson]

> On Aug. 24, 2014, 10:53 p.m., David Edmundson wrote:
> > src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml, line 40
> > <https://git.reviewboard.kde.org/r/119920/diff/1/?file=307465#file307465line40>
> >
> >     int gridUnit = QFontMetrics(QGuiApplication::font()).boundingRect("M").height();;
> >     
> >     
> >     so units.gridUnit should be the same as the theme.mSize(theme.defaultFont).height already.
> >     
> >     it's /should/ just the margins that need adding to make it consistent.
> >     
> >     If that's not the case it means there's something bigger we need to fix in units.
> 
> Marco Martin wrote:
>     the height of controls is at the moment in fonts, since the height of things with labels in the end with always depends from their fonts.
>     
>     gridunit should be the same thing for now, but is not guaranteed it will stay that way (in fact i don't think is a good idea to use font heights for the unit, it's just the only one that happens to work for now)

Oh that makes sense. Revert my comment and ship it.
Sorry.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119920/#review65162
-----------------------------------------------------------


On Sept. 6, 2014, 7:46 a.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119920/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2014, 7:46 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This patch restores the original checkbox and radio button size calculation as it was before the migration to QtQuick Controls.
> 
> On one hand the newer, smaller one size-wise looks closer to the one used in Widget/Desktop-style apps but eg. battery monitor looks weird with the smaller one.
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmacomponents/qml/styles/CheckBoxStyle.qml d9dc9fd 
>   src/declarativeimports/plasmacomponents/qml/styles/RadioButtonStyle.qml 6d06f01 
> 
> Diff: https://git.reviewboard.kde.org/r/119920/diff/
> 
> 
> Testing
> -------
> 
> CheckBox looks like it did before, did not test Radio Button, in Radio Button it also does away with the hardcoded 6px margin used previously.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20140906/95a561a4/attachment.html>