Review Request 120746: Fix build of keyboards kcm on debian-based systems
Martin Klapetek
martin.klapetek at gmail.com
Thu Oct 23 12:14:30 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120746/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 12:14 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Repository: plasma-desktop
Description
-------
e5741584 reintroduced xcb xinput code and added a "#include <xcb/xinput.h>" without properly looking for xinput in cmake (and was placed in wrong ifdef).
This makes cmake look for xcb xinput and properly ifdef the code if xcb/xinput.h is not found; for example debian-based systems ship xcb without xinput altogether.
Diffs
-----
CMakeLists.txt 7e2ccd6
kcms/keyboard/CMakeLists.txt f05be16
kcms/keyboard/xinput_helper.cpp f15fbdf
Diff: https://git.reviewboard.kde.org/r/120746/diff/
Testing
-------
Everything built fine.
Thanks,
Martin Klapetek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141023/683e40d1/attachment.html>
More information about the Plasma-devel
mailing list