Review Request 119589: Allow KHelpCenter from Plasma 5 to work with KDE4 applications.

Scarlett Clark sgclark at kubuntu.org
Tue Oct 21 20:52:25 UTC 2014



> On Oct. 21, 2014, 1:47 p.m., Luigi Toscano wrote:
> > Uhm, I think the patch can go in. It's not breaking existing stuff and there are no conflicts with existing files.

just an FYI I had to adjust this patch to line 92 for it to apply.


- Scarlett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119589/#review68851
-----------------------------------------------------------


On Aug. 3, 2014, 9:59 a.m., Matthew Dawson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119589/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2014, 9:59 a.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: khelpcenter
> 
> 
> Description
> -------
> 
> KHelpCenter 5.0.0 works with handbooks from KDE4 applications, but by
> default they cannot launch it.  Fix that so KDE4 applications don't lose
> their help when someone upgrades to Plasma 5.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 728b2583c052fd09e85ef66aa3e99d092948837d 
> 
> Diff: https://git.reviewboard.kde.org/r/119589/diff/
> 
> 
> Testing
> -------
> 
> Tested installing a manual patch against my system install.  Hitting F1 in dolphin launches KHelpCenter as expected, with the dolphin help displayed (after running kbuildsyscoca4).
> 
> 
> Thanks,
> 
> Matthew Dawson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141021/512e71d6/attachment-0001.html>


More information about the Plasma-devel mailing list