Review Request 119589: Allow KHelpCenter from Plasma 5 to work with KDE4 applications.
Luigi Toscano
luigi.toscano at tiscali.it
Tue Oct 21 20:47:27 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119589/#review68851
-----------------------------------------------------------
Ship it!
Uhm, I think the patch can go in. It's not breaking existing stuff and there are no conflicts with existing files.
- Luigi Toscano
On Aug. 3, 2014, 6:59 p.m., Matthew Dawson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119589/
> -----------------------------------------------------------
>
> (Updated Aug. 3, 2014, 6:59 p.m.)
>
>
> Review request for Documentation and Plasma.
>
>
> Repository: khelpcenter
>
>
> Description
> -------
>
> KHelpCenter 5.0.0 works with handbooks from KDE4 applications, but by
> default they cannot launch it. Fix that so KDE4 applications don't lose
> their help when someone upgrades to Plasma 5.
>
>
> Diffs
> -----
>
> CMakeLists.txt 728b2583c052fd09e85ef66aa3e99d092948837d
>
> Diff: https://git.reviewboard.kde.org/r/119589/diff/
>
>
> Testing
> -------
>
> Tested installing a manual patch against my system install. Hitting F1 in dolphin launches KHelpCenter as expected, with the dolphin help displayed (after running kbuildsyscoca4).
>
>
> Thanks,
>
> Matthew Dawson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141021/681f4d23/attachment.html>
More information about the Plasma-devel
mailing list