Review Request 120624: add gtkbreeze, kconf_update tool to set gtk settings on first login

[Jonathan Riddell]

> On Oct. 17, 2014, 5:59 p.m., Andrew Lake wrote:
> > Sorry if it's too much trouble, but would you be able to do a screenshot showing a gtk app with these settings alongside a KF5 app?
> 
> Jonathan Riddell wrote:
>     http://people.ubuntu.com/~jr/tmp/breeze-gtk2.png  GTK 2
>     http://people.ubuntu.com/~jr/tmp/breeze-gtk3.png  GTK 3 (the demo app uses client side windows but the window border is still shown, I'm told this bug is fixed in newer GTK)
>     http://people.ubuntu.com/~jr/tmp/breeze-qt4.png  Qt 4
> 
> Martin Gräßlin wrote:
>     for GTK 3 it's important that the style doesn't set a shadow because that's causing the strange effect you have in the screenshot.
> 
> Andrew Lake wrote:
>     Just on the visual result, I think the proposal is quite reasonable. There's a QtCurve Breeze settings file available in the breeze repo that comes pretty close to matching the feel of the native Breeze style, but I'm not aware of a QtCurve implementation in GTK3 (is there?). So I'm fine with this solution to keeping GTK2/3 apps looking similar and not looking too out of place when running in Plasma.

Right the QtCurve GTK3 port was abandoned because GTK3 removed useful themeing abilities


- Jonathan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120624/#review68621
-----------------------------------------------------------


On Oct. 19, 2014, 3:15 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120624/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2014, 3:15 p.m.)
> 
> 
> Review request for Plasma and Hugo Pereira Da Costa.
> 
> 
> Repository: breeze
> 
> 
> Description
> -------
> 
> add gtkbreeze, kconf_update tool to set gtk settings on first login
> this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits
> it does this for both gtk 2 and 3
> it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze
> it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3
> I also could not get icons to show on buttons or in menus in gtk 3
> 
> 
> Diffs
> -----
> 
>   misc/CMakeLists.txt ff891a9 
>   misc/gtkbreeze/CMakeLists.txt PRE-CREATION 
>   misc/gtkbreeze/gtkbreeze.upd PRE-CREATION 
>   misc/gtkbreeze/main.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/120624/diff/
> 
> 
> Testing
> -------
> 
> run it and run gtk-demo and gtk3-demo
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141020/2a947a44/attachment.html>