<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120624/">https://git.reviewboard.kde.org/r/120624/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 17th, 2014, 5:59 p.m. UTC, <b>Andrew Lake</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry if it's too much trouble, but would you be able to do a screenshot showing a gtk app with these settings alongside a KF5 app?</p></pre>
</blockquote>
<p>On October 19th, 2014, 3:24 p.m. UTC, <b>Jonathan Riddell</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">http://people.ubuntu.com/~jr/tmp/breeze-gtk2.png GTK 2
http://people.ubuntu.com/~jr/tmp/breeze-gtk3.png GTK 3 (the demo app uses client side windows but the window border is still shown, I'm told this bug is fixed in newer GTK)
http://people.ubuntu.com/~jr/tmp/breeze-qt4.png Qt 4</p></pre>
</blockquote>
<p>On October 19th, 2014, 3:48 p.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">for GTK 3 it's important that the style doesn't set a shadow because that's causing the strange effect you have in the screenshot.</p></pre>
</blockquote>
<p>On October 20th, 2014, 3:42 a.m. UTC, <b>Andrew Lake</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just on the visual result, I think the proposal is quite reasonable. There's a QtCurve Breeze settings file available in the breeze repo that comes pretty close to matching the feel of the native Breeze style, but I'm not aware of a QtCurve implementation in GTK3 (is there?). So I'm fine with this solution to keeping GTK2/3 apps looking similar and not looking too out of place when running in Plasma.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Right the QtCurve GTK3 port was abandoned because GTK3 removed useful themeing abilities</p></pre>
<br />
<p>- Jonathan</p>
<br />
<p>On October 19th, 2014, 3:15 p.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma and Hugo Pereira Da Costa.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Oct. 19, 2014, 3:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">add gtkbreeze, kconf_update tool to set gtk settings on first login
this checks if gtk settings are already set, if they are not or are set to oxygen they update them, else it quits
it does this for both gtk 2 and 3
it sets gtk to the orion theme because it's available for both gtk 2 and 3 and it looks similar to breeze
it sets the icons to oxygen because I could not get breeze icons to work with gtk 2 or 3
I also could not get icons to show on buttons or in menus in gtk 3</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">run it and run gtk-demo and gtk3-demo</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>misc/CMakeLists.txt <span style="color: grey">(ff891a9)</span></li>
<li>misc/gtkbreeze/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>misc/gtkbreeze/gtkbreeze.upd <span style="color: grey">(PRE-CREATION)</span></li>
<li>misc/gtkbreeze/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120624/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>