Review Request 120602: Fix glitching Alternatives dialog
Kai Uwe Broulik
kde at privat.broulik.de
Wed Oct 15 21:40:48 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120602/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 9:40 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and Marco Martin.
Bugs: 340003
https://bugs.kde.org/show_bug.cgi?id=340003
Repository: plasma-desktop
Description
-------
Fixes a porting oversight and also takes into account the buttons and heading.
Apparently when a dialog does not explicitly set a mainItem, the Dialog tries to guess the size from the children of the dialog which was anchors.fill and then it got confused.
Diffs
-----
desktoppackage/contents/explorer/AppletAlternatives.qml 4e97dc9
Diff: https://git.reviewboard.kde.org/r/120602/diff/
Testing
-------
Dialog flies in smoothly trying to display the list without scrollbars but is still properly max'd to not fill the entire screen.
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141015/1894d89a/attachment.html>
More information about the Plasma-devel
mailing list