Review Request 120276: Initial port to frameworks for the comic dataengine.

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120276/#review68304
-----------------------------------------------------------



dataengines/comic/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120276/#comment47615>

    Is the KDELibs4Support needed only because of the KStandardDirs? If yes, then let's port away from that as well, it's easy enough



dataengines/comic/CMakeLists.txt
<https://git.reviewboard.kde.org/r/120276/#comment47606>

    These two could be merged into one



dataengines/comic/comic_package.cpp
<https://git.reviewboard.kde.org/r/120276/#comment47609>

    These should use the <> brackets



dataengines/comic/comic_package_plugin.cpp
<https://git.reviewboard.kde.org/r/120276/#comment47607>

    I think this should just go into comic_package.cpp to follow all the other exports, then this file can be removed



dataengines/comic/comicproviderkross.cpp
<https://git.reviewboard.kde.org/r/120276/#comment47611>

    This should use the <> brackets



dataengines/comic/comicproviderkross.cpp
<https://git.reviewboard.kde.org/r/120276/#comment47610>

    Remove if not needed



dataengines/comic/comicproviderwrapper.cpp
<https://git.reviewboard.kde.org/r/120276/#comment47612>

    The coding style is no spaces inside ()s (I know it's not your code, but since you're touching it already, let's fix it)
    
    Also, do we need all this kind of information actually printed in the log?



dataengines/comic/comicproviderwrapper.cpp
<https://git.reviewboard.kde.org/r/120276/#comment47613>

    No spaces in ()s



dataengines/comic/comicproviderwrapper.cpp
<https://git.reviewboard.kde.org/r/120276/#comment47614>

    No spaces in ()s


- Martin Klapetek


On Oct. 12, 2014, 6:06 p.m., Andrei Amuraritei wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120276/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2014, 6:06 p.m.)
> 
> 
> Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> comic DataEngine initial port to frameworks.
> 
> 
> Diffs
> -----
> 
>   dataengines/comic/comicproviderkross.h 46a9072 
>   dataengines/comic/comicproviderkross.cpp 9820f05 
>   dataengines/comic/comicproviderwrapper.h 81eee68 
>   dataengines/CMakeLists.txt 04c7985 
>   dataengines/comic/CMakeLists.txt 8e382e6 
>   dataengines/comic/cachedprovider.h baac8a9 
>   dataengines/comic/cachedprovider.cpp caca25e 
>   dataengines/comic/comic.h 8cc3969 
>   dataengines/comic/comic.cpp 7130f44 
>   dataengines/comic/comic_package.h 32be381 
>   dataengines/comic/comic_package.cpp 6d2ff0b 
>   dataengines/comic/comic_package_plugin.cpp d997947 
>   dataengines/comic/comicprovider.h 630ee8d 
>   dataengines/comic/comicprovider.cpp ab248a5 
>   dataengines/comic/comicproviderwrapper.cpp 48ced42 
> 
> Diff: https://git.reviewboard.kde.org/r/120276/diff/
> 
> 
> Testing
> -------
> 
> Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages.
> This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts.
> Thanks notmart, d_ed, sebas, bshas etc for helping.
> 
> 
> Thanks,
> 
> Andrei Amuraritei
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141013/5d352e08/attachment-0001.html>