<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120276/">https://git.reviewboard.kde.org/r/120276/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120276/diff/3/?file=317961#file317961line12" style="color: black; font-weight: bold; text-decoration: underline;">dataengines/comic/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KF5::KDELibs4Support</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Is the KDELibs4Support needed only because of the KStandardDirs? If yes, then let's port away from that as well, it's easy enough</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120276/diff/3/?file=317961#file317961line51" style="color: black; font-weight: bold; text-decoration: underline;">dataengines/comic/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span> <span class="s">plasmacomicprovidercore</span><span class="hl"> </span><span class="o"><span class="hl">${</span></span><span class="nv"><span class="hl">KDE4_KDEUI_LIBS</span></span><span class="o"><span class="hl">}</span></span><span class="hl"> </span><span class="o"><span class="hl">${</span></span><span class="nv"><span class="hl">KDE4_KIO_LIBS</span></span><span class="o"><span class="hl">}</span></span><span class="hl"> </span><span class="o"><span class="hl">${</span></span><span class="nv"><span class="hl">KDE4_KROSSCORE_LIBS</span></span><span class="o"><span class="hl">}</span></span><span class="hl"> </span><span class="p"><span class="hl">)</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">51</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span> <span class="s">plasmacomicprovidercore</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span> <span class="s">plasmacomicprovidercore</span> <span class="s">LINK_INTERFACE_LIBRARIES</span> <span class="o">${</span><span class="nv">KDE4_KDECORE_LIBS</span><span class="o">}</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">52</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KF5::WidgetsAddons</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">53</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KF5::KIOCore</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KF5::KrossCore</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">55</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KF5::KrossUi</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">56</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KF5::I18n</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">57</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KF5::KDELibs4Support</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">58</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="p">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">59</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">target_link_libraries</span><span class="p">(</span> <span class="s">plasmacomicprovidercore</span> <span class="s">LINK_INTERFACE_LIBRARIES</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">60</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">KF5::KDELibs4Support</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">61</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">These two could be merged into one</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120276/diff/3/?file=317967#file317967line21" style="color: black; font-weight: bold; text-decoration: underline;">dataengines/comic/comic_package.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "<span class="hl">p</span>lasma/<span class="hl">a</span>pplet<span class="hl">.h</span>"</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "<span class="hl">P</span>lasma/<span class="hl">A</span>pplet"</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">22</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "<span class="hl">p</span>lasma/<span class="hl">p</span>ackage<span class="hl">.h</span>"</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">22</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "<span class="hl">P</span>lasma/<span class="hl">P</span>ackage"</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">23</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "KLocalizedString"</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">These should use the <> brackets</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120276/diff/3/?file=317968#file317968line21" style="color: black; font-weight: bold; text-decoration: underline;">dataengines/comic/comic_package_plugin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">K_EXPORT_PLASMA_PACKAGESTRUCTURE</span><span class="p">(</span><span class="n">comic</span><span class="p">,</span> <span class="n">ComicPackage</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">K_EXPORT_PLASMA_PACKAGE_WITH_JSON</span><span class="p">(</span><span class="n">ComicPackage</span><span class="p">,</span> <span class="s">"plasma-packagestructure-comic.json"</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I think this should just go into comic_package.cpp to follow all the other exports, then this file can be removed</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120276/diff/3/?file=317972#file317972line21" style="color: black; font-weight: bold; text-decoration: underline;">dataengines/comic/comicproviderkross.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">21</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#include "KPluginFactory"</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This should use the <> brackets</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120276/diff/3/?file=317972#file317972line23" style="color: black; font-weight: bold; text-decoration: underline;">dataengines/comic/comicproviderkross.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">COMICPROVIDER_EXPORT_PLUGIN( ComicProviderKross, "ComicProviderKross", "" )</pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">22</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">COMICPROVIDER_EXPORT_PLUGIN</span><span class="p">(</span> <span class="n">ComicProviderKross</span><span class="p">,</span> <span class="s">"ComicProviderKross"</span><span class="p">,</span> <span class="s">""</span> <span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">23</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c1"><span class="hl">//</span>COMICPROVIDER_EXPORT_PLUGIN( ComicProviderKross, "ComicProviderKross", "" )</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Remove if not needed</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120276/diff/3/?file=317974#file317974line762" style="color: black; font-weight: bold; text-decoration: underline;">dataengines/comic/comicproviderwrapper.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ComicProviderWrapper::pageError( int id, const QString &message )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">750</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">k</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Author"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">comicAuthor</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">762</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">q</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Author"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">comicAuthor</span><span class="p">();</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">751</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">k</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Website URL"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mWebsiteUrl</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">763</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">q</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Website URL"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mWebsiteUrl</span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">752</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">k</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Shop URL"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mShopUrl</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">764</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">q</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Shop URL"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mShopUrl</span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">753</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">k</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Title"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mTitle</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">765</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">q</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Title"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mTitle</span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">754</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">k</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Additional Text"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mAdditionalText</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">766</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">q</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Additional Text"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mAdditionalText</span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">755</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">k</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Identifier"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mIdentifier</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">767</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">q</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Identifier"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mIdentifier</span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">756</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">k</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"First Identifier"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mFirstIdentifier</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">768</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">q</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"First Identifier"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mFirstIdentifier</span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">757</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">k</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Last Identifier"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mLastIdentifier</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">769</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">q</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Last Identifier"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mLastIdentifier</span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">758</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">k</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Next Identifier"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mNextIdentifier</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">770</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">q</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Next Identifier"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mNextIdentifier</span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">759</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">k</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Previous Identifier"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mPreviousIdentifier</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">771</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n"><span class="hl">q</span>Debug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">QString</span><span class="p">(</span> <span class="n">QLatin1String</span><span class="p">(</span> <span class="s">"Previous Identifier"</span> <span class="p">)</span> <span class="p">).</span><span class="n">leftJustified</span><span class="p">(</span> <span class="mi">22</span><span class="p">,</span> <span class="n">QLatin1Char</span><span class="p">(</span> <span class="sc">'.'</span> <span class="p">)</span> <span class="p">)</span> <span class="o"><<</span> <span class="n">mPreviousIdentifier</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The coding style is no spaces inside ()s (I know it's not your code, but since you're touching it already, let's fix it)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, do we need all this kind of information actually printed in the log?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120276/diff/3/?file=317974#file317974line787" style="color: black; font-weight: bold; text-decoration: underline;">dataengines/comic/comicproviderwrapper.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ComicProviderWrapper::requestPage( const QString &url, int id, const QVariantMap &infos )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">775</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">mProvider</span><span class="o">-></span><span class="n">requestPage</span><span class="p">(</span> <span class="n"><span class="hl">K</span>Url</span><span class="p">(</span> <span class="n">url</span> <span class="p">),</span> <span class="n">id</span><span class="p">,</span> <span class="n">map</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">787</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">mProvider</span><span class="o">-></span><span class="n">requestPage</span><span class="p">(</span> <span class="n"><span class="hl">Q</span>Url</span><span class="p">(</span> <span class="n">url</span> <span class="p">),</span> <span class="n">id</span><span class="p">,</span> <span class="n">map</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No spaces in ()s</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120276/diff/3/?file=317974#file317974line798" style="color: black; font-weight: bold; text-decoration: underline;">dataengines/comic/comicproviderwrapper.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void ComicProviderWrapper::requestPage( const QString &url, int id, const QVariantMap &infos )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">786</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">mProvider</span><span class="o">-></span><span class="n">requestRedirectedUrl</span><span class="p">(</span> <span class="n"><span class="hl">K</span>Url</span><span class="p">(</span> <span class="n">url</span> <span class="p">),</span> <span class="n">id</span><span class="p">,</span> <span class="n">map</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">798</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">mProvider</span><span class="o">-></span><span class="n">requestRedirectedUrl</span><span class="p">(</span> <span class="n"><span class="hl">Q</span>Url</span><span class="p">(</span> <span class="n">url</span> <span class="p">),</span> <span class="n">id</span><span class="p">,</span> <span class="n">map</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No spaces in ()s</p></pre>
</div>
</div>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On October 12th, 2014, 6:06 p.m. CEST, Andrei Amuraritei wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, David Edmundson, Marco Martin, and Sebastian Kügler.</div>
<div>By Andrei Amuraritei.</div>
<p style="color: grey;"><i>Updated Oct. 12, 2014, 6:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">comic DataEngine initial port to frameworks.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Building from source, compiles 100%, some deprecated warnings. DataEngine shows up in plasmaengineexplorer and detects installed .comic packages.
This is the initial port, still need to review code to fix issues like whitespaces around ( or the deprecated parts.
Thanks notmart, d_ed, sebas, bshas etc for helping.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dataengines/comic/comicproviderkross.h <span style="color: grey">(46a9072)</span></li>
<li>dataengines/comic/comicproviderkross.cpp <span style="color: grey">(9820f05)</span></li>
<li>dataengines/comic/comicproviderwrapper.h <span style="color: grey">(81eee68)</span></li>
<li>dataengines/CMakeLists.txt <span style="color: grey">(04c7985)</span></li>
<li>dataengines/comic/CMakeLists.txt <span style="color: grey">(8e382e6)</span></li>
<li>dataengines/comic/cachedprovider.h <span style="color: grey">(baac8a9)</span></li>
<li>dataengines/comic/cachedprovider.cpp <span style="color: grey">(caca25e)</span></li>
<li>dataengines/comic/comic.h <span style="color: grey">(8cc3969)</span></li>
<li>dataengines/comic/comic.cpp <span style="color: grey">(7130f44)</span></li>
<li>dataengines/comic/comic_package.h <span style="color: grey">(32be381)</span></li>
<li>dataengines/comic/comic_package.cpp <span style="color: grey">(6d2ff0b)</span></li>
<li>dataengines/comic/comic_package_plugin.cpp <span style="color: grey">(d997947)</span></li>
<li>dataengines/comic/comicprovider.h <span style="color: grey">(630ee8d)</span></li>
<li>dataengines/comic/comicprovider.cpp <span style="color: grey">(ab248a5)</span></li>
<li>dataengines/comic/comicproviderwrapper.cpp <span style="color: grey">(48ced42)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120276/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>