Review Request 120516: introduce bool applicationMode for standalone application mode

[Bhushan Shah]

> On Oct. 6, 2014, 11:11 p.m., Marco Martin wrote:
> > drkonqi/data/debuggers/internal/gdbrc, line 76
> > <https://git.reviewboard.kde.org/r/120516/diff/1/?file=316819#file316819line76>
> >
> >     this seems to be unrelated

Sorry this is patch to get my drkonqi working.. removed.


> On Oct. 6, 2014, 11:11 p.m., Marco Martin wrote:
> > shell/desktopview.h, line 36
> > <https://git.reviewboard.kde.org/r/120516/diff/1/?file=316820#file316820line36>
> >
> >     it can be CONSTANT, the mode is not going to change

If I use CONSTANT, setApplicationMode have no effect. it is always false (i.e what set in the ctor), I guess I will need NOTIFY signal as is used in the qml file.


- Bhushan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120516/#review68014
-----------------------------------------------------------


On Oct. 7, 2014, 9:54 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120516/
> -----------------------------------------------------------
> 
> (Updated Oct. 7, 2014, 9:54 a.m.)
> 
> 
> Review request for Plasma and Marco Martin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> this can be used by shell package to know if it is opened in application mode or full shell
> 
> 
> Diffs
> -----
> 
>   shell/desktopview.h 1b07261 
>   shell/desktopview.cpp dcd002d 
>   shell/standaloneappcorona.cpp dd9b69b 
> 
> Diff: https://git.reviewboard.kde.org/r/120516/diff/
> 
> 
> Testing
> -------
> 
> tested with pmc
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141007/e636eb18/attachment.html>