Review Request 120516: introduce bool applicationMode for standalone application mode
Marco Martin
notmart at gmail.com
Mon Oct 6 17:40:59 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120516/#review68014
-----------------------------------------------------------
I am not sure i like exposing a bool, may be the only way.
fo sure the signal would have to go
drkonqi/data/debuggers/internal/gdbrc
<https://git.reviewboard.kde.org/r/120516/#comment47410>
this seems to be unrelated
shell/desktopview.h
<https://git.reviewboard.kde.org/r/120516/#comment47409>
it can be CONSTANT, the mode is not going to change
- Marco Martin
On Ott. 6, 2014, 5:37 p.m., Bhushan Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120516/
> -----------------------------------------------------------
>
> (Updated Ott. 6, 2014, 5:37 p.m.)
>
>
> Review request for Plasma and Marco Martin.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> this can be used by shell package to know if it is opened in application mode or full shell
>
>
> Diffs
> -----
>
> drkonqi/data/debuggers/internal/gdbrc d998c66
> shell/desktopview.h 1b07261
> shell/desktopview.cpp dcd002d
> shell/standaloneappcorona.cpp dd9b69b
>
> Diff: https://git.reviewboard.kde.org/r/120516/diff/
>
>
> Testing
> -------
>
> tested with pmc
>
>
> Thanks,
>
> Bhushan Shah
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141006/ccd9ce0d/attachment.html>
More information about the Plasma-devel
mailing list