Review Request 120500: Remove VLC workaround

[Martin Klapetek]

> On Oct. 5, 2014, 3:11 p.m., Martin Klapetek wrote:
> > > VLC no longer seems to be exposing multiple mpris interfaces
> > 
> > Kubuntu 14.04, VLC 2.1.4 and I still see two mpris interfaces. I'll try the patch out in the evening.
> 
> Kai Uwe Broulik wrote:
>     Kubuntu 14.10, VLC 2.2.0-pre2 here.
>     
>     Maybe they fixed that for the 2.2 version, so probably for master then instead of Plasma/5.1

Well we still need to have something for the people running < 2.2.0, so I'd suggest to actually revert the logic - watch only the .vlc interface rather than the .vlc.instanceNNNN interfaces. This does however limit it to control only one single instance of VLC while you can be running multiple instances of VLC with multiple mpris interfaces. On the other hand, we can always declare that as unsupported ;)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120500/#review67957
-----------------------------------------------------------


On Oct. 5, 2014, 3:09 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120500/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2014, 3:09 p.m.)
> 
> 
> Review request for Plasma, Bhushan Shah and Martin Klapetek.
> 
> 
> Bugs: 332584
>     https://bugs.kde.org/show_bug.cgi?id=332584
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> commit a998595ff7fa0751c894987e2a046ef685169ef5
> Author: Kai Uwe Broulik <kde at privat.broulik.de>
> Date:   Sun Oct 5 15:03:56 2014 +0200
> 
>     Revert "Fix mediacontroller showing twice for VLC"
>     
>     VLC no longer seems to be exposing multiple mpris interfaces, and also the
>     media controller should only be shown once regardless of this.
>     This fixes mediacontroller not working when Plasma starts after VLC (crash recovery)
>     
>     CCBUG: 332584
>     
>     This reverts commit f18ef033332d27a060e5db37f99ce359796f4d61.
> 
> 
> Diffs
> -----
> 
>   dataengines/mpris2/mpris2engine.cpp 42ca565 
> 
> Diff: https://git.reviewboard.kde.org/r/120500/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20141006/c458e0f7/attachment-0001.html>